From 4aaa6422e464490b5bd5e17182300bf84b98b752 Mon Sep 17 00:00:00 2001 From: Darryn Ten Date: Fri, 17 Feb 2017 19:18:33 +0200 Subject: [PATCH 1/3] Ignore clover.xml --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 5265e54..0c91b70 100644 --- a/.gitignore +++ b/.gitignore @@ -3,3 +3,4 @@ composer.lock /vendor/ /bin/ /tests/coverage/ +clover.xml From 8492ca6ad600338cb4d1e4b37d1fd21adcf1c31a Mon Sep 17 00:00:00 2001 From: Darryn Ten Date: Fri, 17 Feb 2017 19:46:08 +0200 Subject: [PATCH 2/3] Adding credits and extra code coverage --- README.md | 5 +++-- phpunit.xml | 1 + src/GoogleNaturalLanguage.php | 2 ++ tests/GoogleNaturalLanguagePhp/GoogleNaturalLanguageTest.php | 2 +- 4 files changed, 7 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 61911a8..b01fe58 100644 --- a/README.md +++ b/README.md @@ -158,6 +158,7 @@ example, only the People, or only the Locations ## Acknowledgements -* Open a PR and put yourself here :) - +* [Dmitry Semenov](https://github.com/mxnr) for being such a legend. +* [Bradley Weston](https://github.com/bweston92) for coming out of nowhere. +* Open a PR and put yourself here :) diff --git a/phpunit.xml b/phpunit.xml index 05c276f..7f33299 100644 --- a/phpunit.xml +++ b/phpunit.xml @@ -37,5 +37,6 @@ + diff --git a/src/GoogleNaturalLanguage.php b/src/GoogleNaturalLanguage.php index 8b6f0ad..50f54b7 100644 --- a/src/GoogleNaturalLanguage.php +++ b/src/GoogleNaturalLanguage.php @@ -11,6 +11,8 @@ * @category Library * @package GoogleNaturalLanguagePhp * @author Darryn Ten + * @author Dmitry Semenov + * @author Bradley Weston * @license MIT * @link https://github.com/darrynten/google-natural-language-php */ diff --git a/tests/GoogleNaturalLanguagePhp/GoogleNaturalLanguageTest.php b/tests/GoogleNaturalLanguagePhp/GoogleNaturalLanguageTest.php index 73a603b..a8d94e7 100644 --- a/tests/GoogleNaturalLanguagePhp/GoogleNaturalLanguageTest.php +++ b/tests/GoogleNaturalLanguagePhp/GoogleNaturalLanguageTest.php @@ -93,7 +93,7 @@ public function testGetSyntax() if (getenv('DO_LIVE_API_TESTS') == "true") { $config = [ 'projectId' => 'project-id', - 'cheapskate' => true, + 'cheapskate' => false, 'cache' => true, ]; From 752b1ce015b0d1d2865eb4959e6ec827cb398114 Mon Sep 17 00:00:00 2001 From: Darryn Ten Date: Fri, 17 Feb 2017 19:51:28 +0200 Subject: [PATCH 3/3] Trying out clover.xml via codecov.io --- .travis.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index c2cc7eb..76a88b3 100644 --- a/.travis.yml +++ b/.travis.yml @@ -10,5 +10,7 @@ before_script: - travis_retry composer install --prefer-dist --no-interaction script: - - bin/phpunit + - bin/phpunit --coverage-clover=coverage.xml +after_success: + - bash <(curl -s https://codecov.io/bash)