Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging / add facility to log the cause of a connection failure #1407

Open
TomKrauss opened this issue Nov 19, 2024 · 0 comments
Open

Comments

@TomKrauss
Copy link

In our project we have sporadic issues in production, where an exception could not be established due to some kind of protocol error. The following line in class Connection terminates a connection, when a protocol error is received swallowing the cause of the error and the (possibly not useful) stack trace, making it almost impossible to track down the root cause of the error:

_terminate(ErrorCode.CONNECT_ERROR, causedByTransportError: true);

Requested is an option to be able to add some kind of error logging to aid debugging connection failures.

There are more places in the Connection class where errors are swallowed (e.g. when running the pingHandler), which might be worth to be considered for better error diagnostics as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant