New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

headersSplitValues doesn't handle set-cookie correctly when header is camel case `Set-Cookie` #1419

Open

laishere opened this issue Dec 10, 2024 · 0 comments

Labels

package:http type-bug

laishere commented Dec 10, 2024

http/pkgs/http/lib/src/base_response.dart

Lines 163 to 167 in e166181

    
           if (key == 'set-cookie') { 
        
             headersWithFieldLists[key] = value.split(_setCookieSplitter); 
        
           } else { 
        
             headersWithFieldLists[key] = value.split(_headerSplitter); 
        
           }

We should use key.toLowerCase() == 'set-cookie' instead.

The text was updated successfully, but these errors were encountered:

laishere added package:http type-bug labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment