From d8dfe29d4c2c3572ae3b27242d0cc7b38c442e9b Mon Sep 17 00:00:00 2001 From: Brian Quinlan Date: Thu, 22 Feb 2024 09:18:00 -0800 Subject: [PATCH] Fix incorrect documentation that used the old `isOwned` name --- pkgs/cronet_http/CHANGELOG.md | 5 +++++ pkgs/cronet_http/README.md | 2 +- pkgs/cronet_http/pubspec.yaml | 2 +- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/pkgs/cronet_http/CHANGELOG.md b/pkgs/cronet_http/CHANGELOG.md index f8b134047d..d2d495e7a1 100644 --- a/pkgs/cronet_http/CHANGELOG.md +++ b/pkgs/cronet_http/CHANGELOG.md @@ -1,3 +1,8 @@ +## 1.1.2-wip + +* Fix a bug in the documentation where `isOwned` is used rather than + `closeEngine`. + ## 1.1.1 * Make it possible to construct `CronetClient` with custom a `CronetEngine` diff --git a/pkgs/cronet_http/README.md b/pkgs/cronet_http/README.md index e53e54d19e..9df4d26910 100644 --- a/pkgs/cronet_http/README.md +++ b/pkgs/cronet_http/README.md @@ -43,7 +43,7 @@ void main() async { cacheMode: CacheMode.memory, cacheMaxSize: 2 * 1024 * 1024, userAgent: 'Book Agent'); - httpClient = CronetClient.fromCronetEngine(engine, isOwned: true); + httpClient = CronetClient.fromCronetEngine(engine, closeEngine: true); } else { httpClient = IOClient(HttpClient()..userAgent = 'Book Agent'); } diff --git a/pkgs/cronet_http/pubspec.yaml b/pkgs/cronet_http/pubspec.yaml index f3cb350ebe..233ec22980 100644 --- a/pkgs/cronet_http/pubspec.yaml +++ b/pkgs/cronet_http/pubspec.yaml @@ -1,5 +1,5 @@ name: cronet_http -version: 1.1.1 +version: 1.1.2-wip description: >- An Android Flutter plugin that provides access to the Cronet HTTP client. repository: https://github.com/dart-lang/http/tree/master/pkgs/cronet_http