Add whereType extension methods for iterables of union extension types.
#71
Conversation
| @@ -514,6 +514,33 @@ extension type StaticTypeDesc.fromJson(Map<String, Object?> node) | |||
| } | |||
| } | |||
|
|
|||
| extension IterableOfStaticTypeDescExtension on Iterable<StaticTypeDesc> { | |||
| Iterable<DynamicTypeDesc> whereTypeDynamicTypeDesc() => | |||
There was a problem hiding this comment.
I worry a bit about exposing these Iterables, especially with the likely high cost of iteration (and map lookups involved) due to the underlying representation here, combined with the lack of composability of them.
I also don't love the naming scheme haha. Maybe just remove the first Type? So, whereDynamicTypeDesc, etc.
There was a problem hiding this comment.
Iteration like this is likely to be common if we have e.g. a Map<String, Member> and you want to iterate over all the members that are Field.
That iteration is actually fast :) the iterable keeps a pointer into the JsonBufferBuilder and just advances to next each time.
Re: naming, yeah, I did think about getting rid of Type, then I realized that if we have a type called Type then you end up with whereType which clashes horribly. So I backed off a bit ;)
Mostly I just sent this because the examples I was writing for the "dart model evolution" doc looked quite ugly without it, no particular urgency to landing it; these are easy to add and should probably be driven by the macro code.
So let's land some macro code first? :)
It occurred to me that this might be a useful type of extension method to add, what do you think?