Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for dev_transformers #670

Closed
DartBot opened this issue Jun 5, 2015 · 5 comments
Closed

add support for dev_transformers #670

DartBot opened this issue Jun 5, 2015 · 5 comments
Labels
closed-duplicate Closed in favor of an existing report type-enhancement A request for a change that isn't a bug

Comments

@DartBot
Copy link

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/2049220?v=3" align="left" width="96" height="96"hspace="10"> Issue by sigmundch
Originally opened as dart-lang/sdk#14187


Brief summary of a discussion we had here in person:

polymer transformers need to read the transitive closure of html files imported from an entry point. This may include assets from other packages. If those packages do not include the polymer transformer, then it's great - we'll be able to read the original assets contents.

It's likely that developers of polymer libraries might want to test their code using polymer's transformers, so we might need a notion of dev_transformers so that those transformations are not visible to other packages.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/2049220?v=3" align="left" width="48" height="48"hspace="10"> Comment by sigmundch


Marked this as blocking dart-archive/polymer-dart#368.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/2049220?v=3" align="left" width="48" height="48"hspace="10"> Comment by sigmundch


quick update/summary of some discussions in person

We recently started running into this problem today (see issue dart-archive/polymer-dart#368).

We used to generate code that was still OK if you applied the polymer transfomer on a library, but a recent change broke that.

We chatted a bit more about this today and discussed some other alternatives, like treating web/ and example/ as subpackages. We concluded that we would like to pursue dev_transformers first. One challenge we discovered is how to combine 'transformers' and 'dev_transformers', but we believe that concatenating the lists might be good enough.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/2049220?v=3" align="left" width="48" height="48"hspace="10"> Comment by sigmundch


we also mention that we wanted to expose a mechanism to declare whether a Transformer is meant to be used in libraries or apps. The idea is to detect if a transformer/transformer group is used correctly.

For example, if polymer is marked as 'app-only', then if you have:

  transformers: [polymer]

you get a warning, but if you use:

  dev_transformers: [polymer]

you don't.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent


Removed Type-Defect label.
Added Type-Enhancement label.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent


Merging this with the other related bug.


Added Duplicate label.
Marked as being merged into dart-archive/barback#39.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-duplicate Closed in favor of an existing report type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

1 participant