Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let barback tell a transformer which inputs were modified #960

Closed
DartBot opened this issue Jun 5, 2015 · 1 comment
Closed

Let barback tell a transformer which inputs were modified #960

DartBot opened this issue Jun 5, 2015 · 1 comment
Labels
closed-duplicate Closed in favor of an existing report type-enhancement A request for a change that isn't a bug

Comments

@DartBot
Copy link

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="96" height="96"hspace="10"> Issue by munificent
Originally opened as dart-lang/sdk#18301


One of the Angular transformers does whole program analysis using the Analyzer. This is pretty time-consuming. To minimize that, it preserves the resolved state across calls to apply().

When apply() is called, it needs to update that state to take into account the inputs that were modified. To minimize the amount of re-analysis it does it wants to only tell the analyzer about the inputs that were changed. Currently, barback doesn't tell the transformer, so it resorts to reading all of the inputs and comparing their contents as strings (!).

Since barback does know that, it would be good to expose that in the Transform API.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent


Added Duplicate label.
Marked as being merged into dart-archive/barback#35.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-duplicate Closed in favor of an existing report type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

1 participant