-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support custom asset types in barback #14966
Comments
+1 on finding a way to avoid serializing them if possible. Pete recently also expressed interested in this. Here is an example use case: we want to be able to parse a dart file and store an AST as a custom asset so we don't have to repeat the parsing later on. cc @blois. |
Would the AST be passed between different transformers, or cached for re-use in a single transformer? |
Different transformers. Ideally these could be completely separate transformers. But I have also scenarios where they could be part of the same transformer group. So those would at least be being part of the same isolate. |
Scenario that I was looking at was a tweak system with support for compiling out the tweaks in release mode. With a series of code transformations such as this, would be nice to not have to re-parse the AST. Potentially the answer is that there should be a single code-transformer which executes a series of AST modifiers. But I imagine that this same scenario could be generalized. |
Removed Area-Library label. |
Removed Library-Barback label. |
This issue has been moved to dart-archive/barback#20. |
Users have expressed an interest in defining custom asset types. This would require some sort of pluggable serialization system in order to send these assets between isolates. Alternately, if we say these assets can only be used by transformers in the same library where they're defined, we could potentially find a way around serializing them.
The text was updated successfully, but these errors were encountered: