Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incomplete units handling causes confusion #99

Open
jbfaden opened this issue Mar 8, 2024 · 1 comment
Open

incomplete units handling causes confusion #99

jbfaden opened this issue Mar 8, 2024 · 1 comment

Comments

@jbfaden
Copy link
Member

jbfaden commented Mar 8, 2024

Right now, units are propagated through some operations. This caused confusion because one dataset in Cindy's script had units. In Cindy's case, if dimensionless and unit-ful data could be added (and I thought it could), the error wouldn't have caused a problem.

@jbfaden
Copy link
Member Author

jbfaden commented Mar 9, 2024

I wrote a new getDataSet command which allows for named parameters, like:

ds1= getDataSet('vap+cdaweb:ds=OMNI2_H0_MRG1HR&id=DST1800','Nov 2018',trim=True, units=None)

which will make it easier to avoid problems caused by units. This will be available as "getDataSet2024" until it is thoroughly verified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant