Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import PlotUtils: palette #27

Open
raman-maker opened this issue Jan 13, 2023 · 1 comment
Open

import PlotUtils: palette #27

raman-maker opened this issue Jan 13, 2023 · 1 comment

Comments

@raman-maker
Copy link

raman-maker commented Jan 13, 2023

Please add

import PlotUtils: palette
in your code .

https://discourse.julialang.org/t/sankey-diagram-in-julia/92884/4
Why there is a comma after "Heat demand" in name collection ??
Please also make Documentation more understandable by including what is meaning of src , dst and weights etc.
The ECharts.jl package gives more interactive sankey diagram so also make changes to make it more interactive like ECharts.jl Sankey plots.

@davide-f
Copy link
Collaborator

davide-f commented Oct 29, 2024

Dear @raman-maker
Apologies for the huge details.
The import PlotUtils is not necessary in SankeyPlots as it is imported through Plots.jl

Regarding the comma after "Heat demand", in lists spanning through multiple lines, it is common practice to add the comma at the end of each element (and line).

I've integrated more documentation in #29. Feel free to revise and comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants