Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support dark mode #59

Open
sjjhsjjh opened this issue May 2, 2021 · 1 comment
Open

Support dark mode #59

sjjhsjjh opened this issue May 2, 2021 · 1 comment
Labels
good-first-issue Issues for people wanting to get involved in the project ready-for-work Ready for someone to pick up

Comments

@sjjhsjjh
Copy link
Collaborator

sjjhsjjh commented May 2, 2021

The Dasher Version Six user interface (UI) should support dark mode.

The control panel and other parts of the UI that are like a web page should have a CSS colour scheme that changes based on the current preference, for example by including a @media (prefers-color-scheme: dark) query. The pagebuilder.css file from the Captive Web View project already has colour scheme that is mostly suitable.

The zooming part of the UI should also have different colours in light and dark modes. One approach could be as follows.

  • In light mode, same colours as current.
  • In dark mode, no fill colours but show white outlines and white text.
@sjjhsjjh sjjhsjjh mentioned this issue May 2, 2021
Open
@willwade
Copy link
Collaborator

Yeah. I think this is wise. Particularly given its now pretty integral to most OS’

@sjjhsjjh we have a colour theme for dasher. Do we make this part of that system ? Like change both overall UI and interface ?

@gavinhenderson gavinhenderson added good-first-issue Issues for people wanting to get involved in the project ready-for-work Ready for someone to pick up good first issue Good for newcomers and removed good-first-issue Issues for people wanting to get involved in the project good first issue Good for newcomers labels Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good-first-issue Issues for people wanting to get involved in the project ready-for-work Ready for someone to pick up
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@willwade @gavinhenderson @sjjhsjjh