Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flag Casing #22

Open
benjamin-t-frost opened this issue Sep 10, 2020 · 1 comment
Open

Flag Casing #22

benjamin-t-frost opened this issue Sep 10, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@benjamin-t-frost
Copy link
Contributor

benjamin-t-frost commented Sep 10, 2020 •
edited
Loading

Use Case:
To avoid confusion and casual mistakes, getters on $ld.flags should be indifferent to casing.

Acceptance Criteria:

  • Interactions with flags should be indifferent between kebab casing and camel casing
    • e.g., $ld.flags['feature-flag'] and $ld.flags.featureFlag
  • The solution should be usable by older browsers
@benjamin-t-frost benjamin-t-frost added the enhancement New feature or request label Sep 10, 2020
@kepheusikarius
Copy link
Contributor

This should also work for LDRouteGuard and the redirects. Ideally, this would also be opt-in to avoid surprises.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kepheusikarius @benjamin-t-frost