refactor: drop usages of llmq/utils to check if hard-fork is active #5753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knst
force-pushed
the
refactor-llmq_vbc
branch
from
8255269 to
689fa42
Compare
UdjinM6
requested changes
Dec 8, 2023
knst
force-pushed
the
refactor-llmq_vbc
branch
from
689fa42 to
dcae438
Compare
UdjinM6
approved these changes
Dec 16, 2023
UdjinM6
previously approved these changes
Dec 16, 2023
|
not sure why github decided to post this ^^^ twice... 🤷♂️ |
PastaPastaPasta
requested changes
Dec 18, 2023
knst
force-pushed
the
refactor-llmq_vbc
branch
from
dcae438 to
3a76107
Compare
knst
force-pushed
the
refactor-llmq_vbc
branch
from
3a76107 to
5956d56
Compare
knst
force-pushed
the
refactor-llmq_vbc
branch
from
5956d56 to
9928d0c
Compare
PastaPastaPasta
approved these changes
Dec 19, 2023
PastaPastaPasta
force-pushed
the
refactor-llmq_vbc
branch
from
9928d0c to
e092b18
Compare
…s have no idea why it is not matching with v19 activation
Note: g_versionbitscache is reset in UnloadBlockIndex()
… EHF logic anymore
…tation Impossible to drop it completelly right now because: - net doesn't know any details about chain - can't check status of fork - the functional test feature_maxuploadtarget.py assume block size 1Mb - DIP0001 can't be activated from regtest early block2 because big txes are not allowed after DIP0001 refactor: drop global variable fDIP0001ActiveAtTip - attempt 2
PastaPastaPasta
force-pushed
the
refactor-llmq_vbc
branch
from
e092b18 to
42e65f4
Compare
5 tasks
PastaPastaPasta
pushed a commit
that referenced
this pull request
Jan 18, 2024
) ## Issue being fixed or feature implemented `llmq/utils` has simple util code that used all over code base and also have too heavy code for calculation quorums such as: `GetAllQuorumMembers`, `EnsureQuorumConnections` and other. These helpers for calculation quorums are used only by evo/deterministicmns, evo/simplifiedmns and llmq/* modules, but llmq/utils is included in many other modules for various trivial helpers. ## What was done? Prior work: - #5753 - #5486 See also #4798 This PR remove all non-quorum calculation code from llmq/utils. Eventually it happens that easier to take everything out rather than move Quorum Calculation to new place atm: - new module llmq/options have a code related to various params, command line options, spork-related etc - llmq/utils is not included in various files which do not use any llmq/utils code - helper `BuildCommitmentHash` goes to llmq/commitment - helper `BuildSignHash` goes to llmq/signing - helper `GetLLMQParam` inlined since it's trivial (it has not been trivial when introduced ages ago) - removed dependency of `IsQuorumEnabled` on CQuorumManager which means `quorumManager` deglobalization is done for 90% ## How Has This Been Tested? - Run unit functional tests - updated circular dependencies `test/lint/lint-circular-dependencies.sh` - check that llmq/utils is not included without needs to calculate Quorums Members ``` $ grep -r include src/ 2> /dev/null | grep -v .Po: | grep -vE 'llmq/utils.(h|cpp)': | grep llmq/utils src/evo/mnauth.cpp:#include <llmq/utils.h> src/evo/deterministicmns.cpp:#include <llmq/utils.h> src/llmq/quorums.cpp:#include <llmq/utils.h> src/llmq/blockprocessor.cpp:#include <llmq/utils.h> src/llmq/commitment.cpp:#include <llmq/utils.h> src/llmq/debug.cpp:#include <llmq/utils.h> src/llmq/dkgsessionhandler.cpp:#include <llmq/utils.h> src/llmq/dkgsession.cpp:#include <llmq/utils.h> src/llmq/dkgsessionmgr.cpp:#include <llmq/utils.h> src/rpc/quorums.cpp:#include <llmq/utils.h> ``` ## Breaking Changes N/A ## Checklist: - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
That's a follow-up changes for #5749 and #5740 (bitcoin#19438)
What was done?
Dropped all usages of llmq/utils to check if any hard-fork is active; as well dropped all direct usages of
chainparamsin favor of a new interfacedeploymentstatusAs positive side effect it removes circular dependency
validation<->llmq/utilsand it exclude including llmq/utils from many other compilation units.How Has This Been Tested?
Run unit/functional tests
Breaking Changes
N/A
Checklist: