chore: remove deprecated gitian #5756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PastaPastaPasta
approved these changes
Dec 6, 2023
|
should be merge commit, not squash (because of backports) |
…r macOS builds e4c0cad ci, gitian: Drop unneeded python3-dev package for macOS builds (Hennadii Stepanov) Pull request description: ACKs for top commit: fanquake: ACK e4c0cad - gitian builds match and I checked that this doesn't end up installed as a side-effect of another package. Tree-SHA512: 520a3909b106a0e005b195c5395691edf62b76ee2df43b6971b7aa193648d68e6dac69cb4f1dc474f594b015a2fc2074061865e571d89365174beb5c1780356f
ab9c342 release: remove gitian (fanquake) Pull request description: Note that this doesn't yet touch any glibc back compat related code. ACKs for top commit: laanwj: Code review ACK ab9c342 Tree-SHA512: 8e2fe3ec1097f54bb11ab9136b43818d90eab5dbb0a663ad6a552966ada4bdb49cc12ff4e66f0ec0ec5400bda5c81f3a3ce70a9ebb6fe1e0db612da9f00a51a7
…om configure 3d70c05 build: remove faketime unsetting and comments from configure.ac (fanquake) Pull request description: We no-longer use [`faketime`](https://github.com/wolfcw/libfaketime) (it used to be required in gitian), so as far as I'm aware, there is no need for us to unset `FAKETIME` or mention it in our build docs. ACKs for top commit: laanwj: Code review ACK 3d70c05 prusnak: Approach ACK 3d70c05 hebasto: ACK 3d70c05, I have reviewed the code and it looks OK, I agree it can be merged. Tree-SHA512: 9cf89d63b81119f3d2f02975a66ec0b93e861993fdb0e4f70538e3be6e0047dc09ce87ef2de40cbf877647a21706b39ddf07240c77765278d383d7a7878cc7eb
PastaPastaPasta
force-pushed
the
gitian-removal
branch
from
e3b40f1 to
75b6c44
Compare
|
FYI: https://github.com/dashpay/gitian-builder and https://github.com/dashpay/gitian.sigs are archived now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
https://github.com/dashpay/dash-issues/issues/61
Deterministic builds with Gitian is deprecated since v20 release.
New releases are switched to Guix
What was done?
Backporting related bitcoin's changes and cleaning up dash specific files:
How Has This Been Tested?
Run command and go through all items:
Breaking Changes
Gitian is dropped
Checklist: