Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport: merge bitcoin#23280 (coalesce chainstate loading sequence between {,non-}unittest codepaths) #6304

Draft
wants to merge 22 commits into
base: develop
Choose a base branch
from

Conversation

kwvg
Copy link
Collaborator

@kwvg kwvg commented Oct 3, 2024

Additional Information

  • Dependent on backport: merge bitcoin#22772, #22987, #23185, #23157, #23173, #23249, #23211, #22677, #23649, #23683, #23636, #22626 (auxiliary backports: part 17) #6296

  • 9162a4f has been omitted because Dash utilizes chainstate initialization to init CEvoDB, CMNHFManager, CDeterministicMNManager, CCreditPoolManager, llmq::CQuorumSnapshotManager, LLMQContext and CChainstateHelper, most of which reside in NodeContext directly or indirectly.

    • Due to one of the backport's intention was to unify code between init.cpp and setup_common.cpp, Dash-specific initialization code (to the extent that it can be moved out non-disruptively) has been spun out into DashChainstateSetup(Close)() so it can be used in setup_common.cpp and validation_chainstatemanager_tests.cpp.

    • The latter of the two is also the reason why DashTestSetup(Close)() (now DashPostChainstateSetup(Close)()) exists

Breaking Changes

None expected.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas (note: N/A)
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation (note: N/A)
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

Copy link

github-actions bot commented Oct 4, 2024

This pull request has conflicts, please rebase.

@kwvg kwvg added this to the 21.2 milestone Oct 5, 2024
Copy link

github-actions bot commented Oct 8, 2024

This pull request has conflicts, please rebase.

@kwvg kwvg modified the milestones: 21.2, 22 Oct 9, 2024
@kwvg kwvg marked this pull request as ready for review October 10, 2024 06:17
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, light ACK 1a0d125

nit: clang format complains a bit

@kwvg
Copy link
Collaborator Author

kwvg commented Oct 15, 2024

Current approach of allowing NodeContext seems to cause problems down the line, marking as draft until resolved

@kwvg kwvg marked this pull request as draft October 15, 2024 09:38
Copy link

This pull request has conflicts, please rebase.

@PastaPastaPasta PastaPastaPasta modified the milestones: 22, 22.1 Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants