-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backport: merge bitcoin#23280 (coalesce chainstate loading sequence between {,non-}unittest codepaths) #6304
base: develop
Are you sure you want to change the base?
Conversation
This pull request has conflicts, please rebase. |
This pull request has conflicts, please rebase. |
Match formatting with what upcoming commits expect to limit conflicts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, light ACK 1a0d125
nit: clang format complains a bit
Current approach of allowing |
This pull request has conflicts, please rebase. |
Additional Information
Dependent on backport: merge bitcoin#22772, #22987, #23185, #23157, #23173, #23249, #23211, #22677, #23649, #23683, #23636, #22626 (auxiliary backports: part 17) #6296
9162a4f has been omitted because Dash utilizes chainstate initialization to init
CEvoDB
,CMNHFManager
,CDeterministicMNManager
,CCreditPoolManager
,llmq::CQuorumSnapshotManager
,LLMQContext
andCChainstateHelper
, most of which reside inNodeContext
directly or indirectly.Due to one of the backport's intention was to unify code between
init.cpp
andsetup_common.cpp
, Dash-specific initialization code (to the extent that it can be moved out non-disruptively) has been spun out intoDashChainstateSetup
(Close
)()
so it can be used insetup_common.cpp
andvalidation_chainstatemanager_tests.cpp
.The latter of the two is also the reason why
DashTestSetup
(Close
)()
(nowDashPostChainstateSetup
(Close
)()
) existsBreaking Changes
None expected.
Checklist