Commits on Nov 23, 2024

1. Merge bitcoin#24067: wallet: Actually treat (un)confirmed txs as (un)… …

   …confirmed
   
   fac8165 Remove unused checkFinalTx (MarcoFalke)
   fa272ea wallet: Avoid dropping confirmed coins (MarcoFalke)
   888841e interfaces: Remove unused is_final (MarcoFalke)
   dddd05e qt: Treat unconfirmed txs as unconfirmed (MarcoFalke)
   
   Pull request description:
   
     The wallet has several issues:
   
     ## Unconfirmed txs in the GUI
   
     The GUI clumsily attempts to guess if unconfirmed txs are locked until a future time. This is currently based on the locktime only, not nSequence, thus wrong. Fix this by removing the clumsy code and treat all unconfirmed txs as unconfirmed. The GUI already prints whether a tx is in the mempool, in which case the user knows that the tx wasn't locked until a future time. If the tx is not in the mempool, it might be better to report the exact reject reason from the mempool instead of using incorrect heuristics.
   
     ## Confirmed txs in the wallet
   
     The wallet drops coins that it incorrectly assumes to be locked until a future time, even if they are already confirmed in the chain. This is because the wallet is using the wrong time (adjusted network time) instead of MTP, due to the `-1` default argument of `CheckFinalTx`.
   
     The issues are fixed in separate commits and there is even a test.
   
   ACKs for top commit:
     achow101:
       ACK fac8165
     prayank23:
       reACK bitcoin@fac8165
     glozow:
       code review ACK fac8165, I understand now how this fixes both issues.
   
   Tree-SHA512: 210afb855f4c6d903fee49eba6b1a9735d699cf0168b669eabb38178e53b3a522258b7cc669f52489c6cd3e38bf358afde12eef3ba2e2f2ffaeb06b8f652ccd0

   

   achow101 authored and vijaydasmp committed Nov 23, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 1f3854d
   • Browse repository at this point

   Copy the full SHA

   1f3854d View commit details

   Browse the repository at this point in the history