backport: merge bitcoin#23235, #23104, #24770, #24830, #24464, #24757, #25202, #25217, #25292, #25614, partial bitcoin#22766 (logging backports)

[kwvg]

Additional Information

• This pull request's primary purpose is to restore LogPrintLevels from backports in dash#6333 that were changed to LogPrints as they were backported before LogPrintLevel was backported.
• clang-format suggestions for LogPrintLevel have to be ignored in order to prevent the linter from tripping due to a "missing newline" (build). Resolved by applying diff (source).
• SharedLock was introduced in dash#5961 and PrintLockContention was removed in dash#6046 but the changes in the latter were not extended to the former. This has been corrected as part of this pull request.

Breaking Changes

None expected.

Checklist

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas (note: N/A)
• I have added or updated relevant unit/integration/functional/e2e tests
• I have made corresponding changes to the documentation
• I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

[UdjinM6]

clang-format suggestions for LogPrintLevel have to be ignored in order to prevent the linter from tripping due to a "missing newline"

should apply suggestions and add /* Continued */ at the eol to make linter happy i.e.

diff --git a/src/llmq/signing_shares.cpp b/src/llmq/signing_shares.cpp
index 0e8a5f2886..f3e53442e3 100644
--- a/src/llmq/signing_shares.cpp
+++ b/src/llmq/signing_shares.cpp
@@ -1346,11 +1346,15 @@ void CSigSharesManager::Cleanup()
                     }
                 }
 
-                LogPrintLevel(BCLog::LLMQ_SIGS, BCLog::Level::Info, "CSigSharesManager::%s -- signing session timed out. signHash=%s, id=%s, msgHash=%s, sigShareCount=%d, missingMembers=%s\n", __func__,
-                              signHash.ToString(), oneSigShare.getId().ToString(), oneSigShare.getMsgHash().ToString(), count, strMissingMembers);
+                LogPrintLevel(BCLog::LLMQ_SIGS, BCLog::Level::Info, /* Continued */
+                              "CSigSharesManager::%s -- signing session timed out. signHash=%s, id=%s, msgHash=%s, "
+                              "sigShareCount=%d, missingMembers=%s\n",
+                              __func__, signHash.ToString(), oneSigShare.getId().ToString(),
+                              oneSigShare.getMsgHash().ToString(), count, strMissingMembers);
             } else {
-                LogPrintLevel(BCLog::LLMQ_SIGS, BCLog::Level::Info, "CSigSharesManager::%s -- signing session timed out. signHash=%s, sigShareCount=%d\n", __func__,
-                              signHash.ToString(), count);
+                LogPrintLevel(BCLog::LLMQ_SIGS, BCLog::Level::Info, /* Continued */
+                              "CSigSharesManager::%s -- signing session timed out. signHash=%s, sigShareCount=%d\n",
+                              __func__, signHash.ToString(), count);
             }
             RemoveSigSharesForSession(signHash);
         }

[UdjinM6]

utACK f5231c1

[PastaPastaPasta]

22766; don't understand why it's partial. Missing changes, appear to be able to be done

[kwvg]

Will correct excluded commit in description, b8c069b is included, c5d7e34 isn't. The latter has been excluded as flags like -legacy and anything -signet*, which are affected by the scripted-diff, haven't been implemented yet.

[knst]

LGTM 1621696

[knst]

LogPrintLevel: nit: I think it's useful to specify in a commit message which exactly prior backports