Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't always set imagePullPolicy to IfNotPresent #769

Closed
consideRatio opened this issue Nov 17, 2023 · 1 comment · Fixed by #770
Closed

Don't always set imagePullPolicy to IfNotPresent #769

consideRatio opened this issue Nov 17, 2023 · 1 comment · Fixed by #770

Comments

@consideRatio
Copy link
Collaborator

I think this should be configured to not default to explicitly setting IfNotPresent but instead omitting it by default. The default behavior when omitted is as Always if the image tag is latest, and otherwise IfNotPresent. This fix would be similar to jupyterhub/kubespawner#807 and shouldn't be a change that is disruptive for users, but rather a possible bugfix.

    image_pull_policy = Unicode(
        "IfNotPresent",
        help="The image pull policy of the docker image specified in ``image``",
        config=True,
    )
@consideRatio
Copy link
Collaborator Author

Closed by #770

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant