Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release #946

Closed
jrbourbeau opened this issue Oct 19, 2022 · 7 comments
Closed

Release #946

jrbourbeau opened this issue Oct 19, 2022 · 7 comments

Comments

@jrbourbeau
Copy link
Member

dask / distributed / scikit-learn all have Python 3.10 support at this point. We should add support for dask-ml too

@hungbui-io
Copy link

hungbui-io commented Mar 7, 2023

Hi @jrbourbeau , I am wondering when dask-ml new version will be released, the one that supports python 3.10?

@jrbourbeau jrbourbeau changed the title Add Python 3.10 support Release Mar 24, 2023
@jrbourbeau
Copy link
Member Author

Thanks for the ping @hungbui-io. In addition to Python 3.10 support, it'd also be good to get a new release out for supporting recent versions of sklearn.

@TomAugspurger is this something you have bandwidth for?

@TomAugspurger
Copy link
Member

Sure, just fixing some metadata in #966 quick (hopefully).

@TomAugspurger
Copy link
Member

Created https://github.com/dask/dask-ml/releases/tag/v2023.3.24. https://github.com/dask/dask-ml/actions/runs/4515711405/jobs/7953319610 is releasing to PyPI.

We'll want to bump the python version in the conda-forge package before that's merged.

@jrbourbeau
Copy link
Member Author

Thanks @TomAugspurger!

@hungbui-io
Copy link

hungbui-io commented Apr 6, 2023

@jrbourbeau @TomAugspurger Thanks for the update. However, I am still facing an issue with 2023.3.24 release when import dask_ml due to the conflict with dask.distributed. Can you pls have a look on this?
Here is the error:

Python 3.10.10 (tags/v3.10.10:aad5f6a, Feb  7 2023, 17:20:36) [MSC v.1929 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import dask_ml
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "C:\Users\...\site-packages\dask_ml\__init__.py", line 4, in <module>
    from dask_ml.model_selection import _normalize
  File "C:\Users\...\site-packages\dask_ml\model_selection\__init__.py", line 6, in <module>
    from ._hyperband import HyperbandSearchCV
  File "C:\Users\...\site-packages\dask_ml\model_selection\_hyperband.py", line 12, in <module>
    from ._incremental import BaseIncrementalSearchCV
  File "C:\Users\...\site-packages\dask_ml\model_selection\_incremental.py", line 19, in <module>
    from dask.distributed import Future, default_client, futures_of, wait
ImportError: cannot import name 'Future' from 'dask.distributed' (C:\Users\...\site-packages\dask\distributed.py)

@TomAugspurger
Copy link
Member

You might try installing things in a new environment to see if the problem is reproducible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants