diff --git a/modules/cloudwatch-alarm-actions/modules/lambda-subscription/README.md b/modules/cloudwatch-alarm-actions/modules/lambda-subscription/README.md index da6d75b..071c48c 100644 --- a/modules/cloudwatch-alarm-actions/modules/lambda-subscription/README.md +++ b/modules/cloudwatch-alarm-actions/modules/lambda-subscription/README.md @@ -16,7 +16,7 @@ No requirements. | Name | Source | Version | |------|--------|---------| -| [alerts](#module\_alerts) | dasmeta/monitoring/aws//modules/alerts | 1.3.4 | +| [alerts](#module\_alerts) | dasmeta/monitoring/aws//modules/alerts | 1.18.1 | | [lambda](#module\_lambda) | terraform-aws-modules/lambda/aws | 4.7.1 | | [subscription](#module\_subscription) | dasmeta/sns/aws//modules//subscription | 1.2.3 | @@ -37,7 +37,7 @@ No requirements. | [dead\_letter\_queue\_arn](#input\_dead\_letter\_queue\_arn) | The SQS queue arn for using as dead letter | `string` | `null` | no | | [environment\_variables](#input\_environment\_variables) | Environment variables to pass to function | `map(any)` | `{}` | no | | [fallback\_sns\_topic\_name](#input\_fallback\_sns\_topic\_name) | The fallback sns topic name to attach/create subscription | `string` | n/a | yes | -| [lambda\_failed\_alert](#input\_lambda\_failed\_alert) | Alert for lambda failed | `any` |
{| no | +| [lambda\_failed\_alert](#input\_lambda\_failed\_alert) | Alert for lambda failed | `any` |
"equation": "gte",
"period": 60,
"statistic": "sum",
"threshold": 1
}
{| no | | [log\_group\_retention\_days](#input\_log\_group\_retention\_days) | The retention days for cloudwatch log group | `number` | `7` | no | | [memory\_size](#input\_memory\_size) | Memory size for Lambda function | `number` | `null` | no | | [recreate\_missing\_package](#input\_recreate\_missing\_package) | Whether to recreate missing Lambda package if it is missing locally or not | `bool` | `true` | no | diff --git a/modules/cloudwatch-alarm-actions/modules/lambda-subscription/main.tf b/modules/cloudwatch-alarm-actions/modules/lambda-subscription/main.tf index 5f72916..0e014e6 100644 --- a/modules/cloudwatch-alarm-actions/modules/lambda-subscription/main.tf +++ b/modules/cloudwatch-alarm-actions/modules/lambda-subscription/main.tf @@ -65,7 +65,7 @@ module "subscription" { module "alerts" { source = "dasmeta/monitoring/aws//modules/alerts" - version = "1.3.4" + version = "1.18.1" sns_topic = var.fallback_sns_topic_name @@ -77,10 +77,11 @@ module "alerts" { filters = { FunctionName = "${local.lambda_name}" } - period = var.lambda_failed_alert.period - threshold = var.lambda_failed_alert.threshold - equation = var.lambda_failed_alert.equation - statistic = var.lambda_failed_alert.statistic + period = var.lambda_failed_alert.period + threshold = var.lambda_failed_alert.threshold + equation = var.lambda_failed_alert.equation + statistic = var.lambda_failed_alert.statistic + fill_insufficient_data = var.lambda_failed_alert.fill_insufficient_data } ] } diff --git a/modules/cloudwatch-alarm-actions/modules/lambda-subscription/variables.tf b/modules/cloudwatch-alarm-actions/modules/lambda-subscription/variables.tf index 34c1a45..f30e401 100644 --- a/modules/cloudwatch-alarm-actions/modules/lambda-subscription/variables.tf +++ b/modules/cloudwatch-alarm-actions/modules/lambda-subscription/variables.tf @@ -83,10 +83,11 @@ variable "recreate_missing_package" { variable "lambda_failed_alert" { type = any default = { - period = 60 - threshold = 1 - equation = "gte" - statistic = "sum" + period = 60 + threshold = 1 + equation = "gte" + statistic = "sum" + fill_insufficient_data = true } description = "Alert for lambda failed " } diff --git a/modules/cloudwatch-alarm-actions/tests/jira/2-assert.tf b/modules/cloudwatch-alarm-actions/tests/jira/2-assert.tf index 909a500..af77633 100644 --- a/modules/cloudwatch-alarm-actions/tests/jira/2-assert.tf +++ b/modules/cloudwatch-alarm-actions/tests/jira/2-assert.tf @@ -1,9 +1,9 @@ -resource "test_assertions" "dummy" { - component = "monitoring-modules-cloudwatch-alarm-actions" +# resource "test_assertions" "dummy" { +# component = "monitoring-modules-cloudwatch-alarm-actions" - equal "scheme" { - description = "As module does not have any output and data just make sure the case runs. Probably can be thrown away." - got = "all good" - want = "all good" - } -} +# equal "scheme" { +# description = "As module does not have any output and data just make sure the case runs. Probably can be thrown away." +# got = "all good" +# want = "all good" +# } +# } diff --git a/modules/cloudwatch-alarm-actions/tests/jira/README.md b/modules/cloudwatch-alarm-actions/tests/jira/README.md index be26234..fbd2dcc 100644 --- a/modules/cloudwatch-alarm-actions/tests/jira/README.md +++ b/modules/cloudwatch-alarm-actions/tests/jira/README.md @@ -9,9 +9,7 @@ ## Providers -| Name | Version | -|------|---------| -| [test](#provider\_test) | n/a | +No providers. ## Modules @@ -21,9 +19,7 @@ ## Resources -| Name | Type | -|------|------| -| [test_assertions.dummy](https://registry.terraform.io/providers/hashicorp/test/latest/docs/resources/assertions) | resource | +No resources. ## Inputs diff --git a/modules/cloudwatch-alarm-actions/tests/teams/0-setup.tf b/modules/cloudwatch-alarm-actions/tests/teams/0-setup.tf index db10e19..df90a19 100644 --- a/modules/cloudwatch-alarm-actions/tests/teams/0-setup.tf +++ b/modules/cloudwatch-alarm-actions/tests/teams/0-setup.tf @@ -1,8 +1,8 @@ terraform { required_providers { - test = { - source = "terraform.io/builtin/test" - } + # test = { + # source = "terraform.io/builtin/test" + # } aws = { source = "hashicorp/aws" diff --git a/modules/cloudwatch-alarm-actions/tests/teams/README.md b/modules/cloudwatch-alarm-actions/tests/teams/README.md index 7a355c3..793e37d 100644 --- a/modules/cloudwatch-alarm-actions/tests/teams/README.md +++ b/modules/cloudwatch-alarm-actions/tests/teams/README.md @@ -23,7 +23,7 @@ | Name | Type | |------|------| -| test_assertions.dummy | resource | +| [test_assertions.dummy](https://registry.terraform.io/providers/hashicorp/test/latest/docs/resources/assertions) | resource | ## Inputs
"equation": "gte",
"fill_insufficient_data": true,
"period": 60,
"statistic": "sum",
"threshold": 1
}