Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle generic/default templates as well as client-specific ones in S2I configs #12

Open
rolfkleef opened this issue Oct 12, 2021 · 0 comments
Labels
Epic Feature New business value visible to the customer (requirement, user story) S2I Updates and changes related to spreadsheet conversions

Comments

@rolfkleef
Copy link
Member

For Luxemburg, we made a change in merge-templates, to make sure MAEE's additional fields are included in the right order (the same way as the IATI elements).

As a result, we have two docker image versions: one with the Luxemburg configuration, one with the generic configuration.

Running locally, we could include the desired docker image tag as an optional workspace configuration variable, to determine which image to use.

Putting it into iati-workbench itself, it might be an optional variable pointing to a subdirectory from where to include the merge-activities template. All variations can then be put into a single docker image. (This might make re-use of "generic" improvements easier, although they also may break client-specific versions.)

Likewise, client-specific XML schemas can be added via this route as well.

@rolfkleef rolfkleef added Feature New business value visible to the customer (requirement, user story) S2I Updates and changes related to spreadsheet conversions Epic labels Oct 12, 2021
@rolfkleef rolfkleef transferred this issue from another repository Feb 9, 2022
@rolfkleef rolfkleef moved this to In Progress in iati-workbench r&d May 16, 2022
@rolfkleef rolfkleef moved this from In Progress to Ready on "develop" in iati-workbench r&d Jun 24, 2022
@rolfkleef rolfkleef moved this from Ready on "develop" to Done in iati-workbench r&d Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic Feature New business value visible to the customer (requirement, user story) S2I Updates and changes related to spreadsheet conversions
Projects
Development

No branches or pull requests

1 participant