Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(query): improve distributed runtime filter #16862

Merged
merged 8 commits into from
Nov 18, 2024
Merged

chore(query): improve distributed runtime filter #16862

merged 8 commits into from
Nov 18, 2024

Conversation

Dousir9
Copy link
Member

@Dousir9 Dousir9 commented Nov 17, 2024 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

In distributed execution, in some cases the scan processor needs to wait for the runtime filter to be generated.

Benchmark

Databend Cloud Medium, TPC-H SF-100
Q17: 16.7s → 6s

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Nov 17, 2024
@Dousir9 Dousir9 added the ci-cloud Build docker image for cloud test label Nov 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-16862-97a030f-1731892791

note: this image tag is only available for internal use,
please check the internal doc for more details.

@Dousir9 Dousir9 requested a review from xudong963 November 18, 2024 05:38
@Dousir9 Dousir9 marked this pull request as ready for review November 18, 2024 05:38
@Dousir9 Dousir9 added this pull request to the merge queue Nov 18, 2024
Merged via the queue into databendlabs:main with commit ed6a0c7 Nov 18, 2024
91 checks passed
@Dousir9 Dousir9 deleted the improve_distributed_runtime_filter branch November 18, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xudong963 xudong963 xudong963 approved these changes

Assignees
No one assigned
Labels
ci-cloud Build docker image for cloud test pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dousir9 @xudong963