From 86a338fae386066e7d95f05c47f7e7516a51354a Mon Sep 17 00:00:00 2001 From: Phoeniix Zhao Date: Wed, 19 Jun 2024 15:12:05 +0800 Subject: [PATCH] Refactor: remove some duplicated code in append_memvership_test.rs --- .../handler/replication_handler/append_membership_test.rs | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/openraft/src/engine/handler/replication_handler/append_membership_test.rs b/openraft/src/engine/handler/replication_handler/append_membership_test.rs index a95e92020..63186ca8e 100644 --- a/openraft/src/engine/handler/replication_handler/append_membership_test.rs +++ b/openraft/src/engine/handler/replication_handler/append_membership_test.rs @@ -55,9 +55,7 @@ fn eng() -> Engine { #[test] fn test_leader_append_membership_for_leader() -> anyhow::Result<()> { let mut eng = eng(); - eng.state.server_state = ServerState::Leader; // Make it a real leader: voted for itself and vote is committed. - eng.state.vote = UTime::new(TokioInstant::now(), Vote::new_committed(2, 2)); eng.vote_handler().become_leading(); eng.replication_handler().append_membership(&log_id(3, 1, 4), &m34()); @@ -107,12 +105,11 @@ fn test_leader_append_membership_update_learner_process() -> anyhow::Result<()> log_id(5, 1, 10), ]); - eng.state.server_state = ServerState::Leader; - // Make it a real leader: voted for itself and vote is committed. - eng.state.vote = UTime::new(TokioInstant::now(), Vote::new_committed(2, 2)); eng.state .membership_state .set_effective(Arc::new(EffectiveMembership::new(Some(log_id(2, 1, 3)), m23_45()))); + + // Make it a real leader: voted for itself and vote is committed. eng.vote_handler().become_leading(); if let Some(l) = &mut eng.internal_server_state.leading_mut() {