Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: trait AsyncOneshotSendExt does not need Unpin #1090

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

drmingdrmer
Copy link
Member

@drmingdrmer drmingdrmer commented Apr 7, 2024

Changelog

Refactor: trait AsyncOneshotSendExt does not need Unpin

This change is Reviewable

@drmingdrmer
Copy link
Member Author

@Miaxos
It looks like AsyncOneshotSendExt does not need to be Unpin?

@drmingdrmer drmingdrmer merged commit 4512491 into databendlabs:main Apr 8, 2024
29 of 30 checks passed
@drmingdrmer drmingdrmer deleted the 61-unpin branch April 8, 2024 05:44
@Miaxos
Copy link
Contributor

Miaxos commented Apr 9, 2024

Hum. I was working mainly on something else recently, I'm going to have a look. I need to resume my work on monoio & openraft

@drmingdrmer
Copy link
Member Author

Hum. I was working mainly on something else recently, I'm going to have a look. I need to resume my work on monoio & openraft

Great, looking forward to your contributions on monoio and openraft. Let me know if you need support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants