Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo: Implement protobuf for RPC #161

Closed
ppamorim opened this issue Feb 5, 2022 · 6 comments
Closed

Demo: Implement protobuf for RPC #161

ppamorim opened this issue Feb 5, 2022 · 6 comments
Assignees

Comments

@ppamorim
Copy link
Contributor

ppamorim commented Feb 5, 2022

Would be nice to have the example using protobuf for the inner communication between nodes. I will implement that in a separated project, if it works I will implement that on the demo, if any interest is present.

@github-actions
Copy link

github-actions bot commented Feb 5, 2022

👋 Thanks for opening this issue!

Get help or engage by:

  • /help : to print help messages.
  • /assignme : to assign this issue to you.

@ppamorim
Copy link
Contributor Author

ppamorim commented Feb 5, 2022

/assignme

@ppamorim
Copy link
Contributor Author

ppamorim commented Feb 5, 2022

@BohuTANG I could implement something but the implementation is TERRIBLE and I am ashamed to ever write this code.

@MikaelCall
Copy link

@ppamorim

The solution that I've seen most often is to use gRPC and tonic. This will be more efficient than using HTTP like the demo is ATM. However, one major benefit of using HTTP in the current demo is that it is very easy to follow (more familiar, no codegen, etc). This is IMHO one of the main benefits with the demo: simplicity. When you want an "advanced demo" more ready for production, look at metasrv in the databend repo. That being said, adding a more efficient RPC mechanism would be nice, but I'd consider having it behind a feature flag and definitely keep the HTTP endpoints for clarity.

@sainad2222
Copy link
Contributor

I tried to pick this but I cannot find any efficient way to reuse responses from existing structs(ClientWriteResponse,VoteResponse etc). Any ideas are welcome

@sainad2222
Copy link
Contributor

@drmingdrmer We can close this too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants