-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Demo: Implement protobuf for RPC #161
Comments
👋 Thanks for opening this issue! Get help or engage by:
|
/assignme |
@BohuTANG I could implement something but the implementation is TERRIBLE and I am ashamed to ever write this code. |
The solution that I've seen most often is to use gRPC and tonic. This will be more efficient than using HTTP like the demo is ATM. However, one major benefit of using HTTP in the current demo is that it is very easy to follow (more familiar, no codegen, etc). This is IMHO one of the main benefits with the demo: simplicity. When you want an "advanced demo" more ready for production, look at metasrv in the databend repo. That being said, adding a more efficient RPC mechanism would be nice, but I'd consider having it behind a feature flag and definitely keep the HTTP endpoints for clarity. |
I tried to pick this but I cannot find any efficient way to reuse responses from existing structs(ClientWriteResponse,VoteResponse etc). Any ideas are welcome |
@drmingdrmer We can close this too |
Would be nice to have the example using protobuf for the inner communication between nodes. I will implement that in a separated project, if it works I will implement that on the demo, if any interest is present.
The text was updated successfully, but these errors were encountered: