Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API trait with GAT #604

Closed
drmingdrmer opened this issue Nov 11, 2022 · 5 comments
Closed

Update API trait with GAT #604

drmingdrmer opened this issue Nov 11, 2022 · 5 comments

Comments

@drmingdrmer
Copy link
Member

https://blog.rust-lang.org/2022/11/03/Rust-1.65.0.html#whats-in-1650-stable

image

@github-actions
Copy link

👋 Thanks for opening this issue!

Get help or engage by:

  • /help : to print help messages.
  • /assignme : to assign this issue to you.

@Xuanwo
Copy link
Member

Xuanwo commented Jan 28, 2024

Hi, this issue has been open for a while. Perhaps we can schedule some actionable tasks to get it started?

@schreter
Copy link
Collaborator

In fact, in the meantime we can simply use async functions in traits (since 1.75). For single-threaded mode, the add_async_trait macro is a no-op and we are using native async fn in trait. @wvwwvwwv implemented that.

For "regular" use, I think there were some concerns regarding Send-ability of the generated futures. But you may try to simply remove async_trait completely and see what happens. If it "simply works" then it would be the best.

@schreter
Copy link
Collaborator

@Xuanwo Ah, I just see there is a PR #996 which addresses this by specifying Send bounds as needed. So this issue is then moot, we should merge that (provided it works, of course - but it seems like it does :-) and with that #959 is completely done. I.e., this is in a way duplicate of #959 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants