Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: add license link #931

Closed
wants to merge 3 commits into from
Closed

Doc: add license link #931

wants to merge 3 commits into from

Conversation

caicancai
Copy link
Contributor

@caicancai caicancai commented Nov 14, 2023

Checklist

  • Updated guide with pertinent info (may not always apply).
  • Squash down commits to one or two logical commits which clearly describe the work you've done.
  • Unittest is a friend:)

This change is Reviewable

@caicancai caicancai closed this Nov 14, 2023
@caicancai caicancai reopened this Nov 14, 2023
@caicancai caicancai marked this pull request as draft November 14, 2023 05:48
@caicancai caicancai marked this pull request as ready for review November 14, 2023 05:48
@caicancai caicancai changed the title Doc : add License link Doc : add license link Nov 14, 2023
@drmingdrmer
Copy link
Member

Thank you man.

The commit message should starts with Doc: not Doc :. The pull request title does not matter.

You could fix it with git commit --amend to update the commit message and git push --force to update the remote branch.

@caicancai
Copy link
Contributor Author

Thank you man.

The commit message should starts with Doc: not Doc :. The pull request title does not matter.

You could fix it with git commit --amend to update the commit message and git push --force to update the remote branch.

Thank you for reminding me

@caicancai caicancai changed the title Doc : add license link Doc: add license link Nov 14, 2023
@caicancai caicancai closed this Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants