Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readme: fix dead link #953

Merged
merged 1 commit into from
Dec 3, 2023
Merged

readme: fix dead link #953

merged 1 commit into from
Dec 3, 2023

Conversation

marvin-j97
Copy link
Contributor

@marvin-j97 marvin-j97 commented Dec 2, 2023 •
edited by drmingdrmer
Loading

This change is Reviewable

@caicancai
Copy link
Contributor

The commit message seems to require a prefix, such as doc

@drmingdrmer
Copy link
Member

Thanks man!
In order to pass the commit message check, you need to update the commit message to Doc: fix dead link with git commit --amend and git push --force

@drmingdrmer drmingdrmer self-requested a review December 3, 2023 07:30
@drmingdrmer drmingdrmer added this pull request to the merge queue Dec 3, 2023
Merged via the queue into databendlabs:main with commit 6df1a9d Dec 3, 2023
24 checks passed
@marvin-j97 marvin-j97 deleted the patch-1 branch December 3, 2023 13:21
@drmingdrmer drmingdrmer mentioned this pull request Mar 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drmingdrmer drmingdrmer drmingdrmer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marvin-j97 @caicancai @drmingdrmer