Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: delete async-trait, fix typo, use tokio to replace async_std #998

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Refactor: delete async-trait, fix typo, use tokio to replace async_std #998

merged 1 commit into from
Jan 29, 2024

Conversation

getong
Copy link
Contributor

@getong getong commented Jan 28, 2024 •
edited by drmingdrmer
Loading

Checklist

  • Updated guide with pertinent info (may not always apply).
  • Squash down commits to one or two logical commits which clearly describe the work you've done.
  • Unittest is a friend:)

This change is Reviewable

@getong getong force-pushed the fix-example-code branch 2 times, most recently from 46dca6c to 8308257 Compare January 29, 2024 05:41
@getong
Copy link
Contributor Author

getong commented Jan 29, 2024

I test it in my repo, the ci result is ok now.
getong#1

@drmingdrmer drmingdrmer self-requested a review January 29, 2024 07:31
drmingdrmer
drmingdrmer approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

drmingdrmer
drmingdrmer approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @getong)

@drmingdrmer drmingdrmer added this pull request to the merge queue Jan 29, 2024
Merged via the queue into databendlabs:main with commit 3ed4228 Jan 29, 2024
27 checks passed
@getong getong deleted the fix-example-code branch January 29, 2024 08:56
@drmingdrmer drmingdrmer mentioned this pull request Mar 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drmingdrmer drmingdrmer drmingdrmer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@getong @drmingdrmer