-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing start=setting line in the core file generated by uniwig #43
Comments
What does the header of the bad Also, unrelated but you should run with cargo install --profile=release --path=gtars/ Then you can just run
|
The line which is causing an issue (line 879394241) looks like this:
For reference, this is what the other fixedStep lines in the same file look like:
|
Looks like it might be this commit: start must be > 0 for wigtobigwig, correct? I reverted a change where I was clamping the start position for the core counts. It was causing other issues but I don't remember now what issues it fixed. You could re-add that line and see if it fixes your issue. Alternatively, (and more recommended) you can use the newest changes in this branch: And simply set the output type to |
This surfaced again. It is happening for core files. Reproducible with simple example where chroms start at 0:
Output for core file that begins like so:
I believe the reason we removed the clamped core position for the core counts is that if you have a wiggle file that spans the entire chromosome from the chrom.sizes file and shift the position in the header by 1, the wiggle file now extends past the chromosome range which causes issues with The proper fix for this is to realize that we are converting a 0 based Bed file to a 1 -based wiggle file. However, to do this we would need to shift before/during counting. BUT we only want to shift for wiggle outputs, not for bedGraph or npy outputs. Therefore, implementing this will require some refactoring. |
Attempted fix above, need to refactor added code to remove duplication
|
I also force an upper bound for the number of counts written to a wiggle file based on chrom size. This was added for downstream tool interoperability. |
Per feedback from @saanikat , the above commits appear to have fixed this issue. |
wigToBigWig
gives me the following issue when I provide the.wig
files generated by uniwig (dev
branch):It seems like some kind of a header line is missing in the core wig file generated by uniwig. The command I used to generate the wiggle files was:
However, when I reset the
dev
branch to commit : 884e7b6 there is no issue withwigToBigWig
indicating that the headerstart=setting
line is generated in this case.To reproduce this error, I have provided the bed file and the chrom sizes file :
/project/shefflab/brickyard/results_pipeline/tlgl_atac/combined_chrsort.bed
/project/shefflab/brickyard/results_pipeline/tlgl_atac/hg38.chrom.sizes
The command I used for wigToBigWig is:
The text was updated successfully, but these errors were encountered: