Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation of the key method to implement to create a Pipeline type is wrong #191

Open
vreuter opened this issue Jul 6, 2023 · 1 comment
Open

Documentation of the key method to implement to create a Pipeline type is wrong #191

vreuter opened this issue Jul 6, 2023 · 1 comment
Labels
bug docs

Comments

@vreuter
Copy link
Member

vreuter commented Jul 6, 2023

Pipeline.stages suggests a collection of names, rather than callables, Stage instances, or the like.

https://github.com/databio/pypiper/blob/master/pypiper/pipeline.py#L175-L179
@vreuter
Copy link
Member Author

vreuter commented Jul 6, 2023

It seems to need to be a collection of pairs of name and callable, or name and Stage (or a mapping from name to callable or stage): https://github.com/databio/pypiper/blob/master/pypiper/pipeline.py#L115-L122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug docs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vreuter