Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for calling mistral for titling (no public API yet) #1168

Merged
merged 7 commits into from
Feb 8, 2024
Merged

Add support for calling mistral for titling (no public API yet) #1168

merged 7 commits into from
Feb 8, 2024
+472 −264

Conversation

dsmilkov
Copy link
Collaborator

@dsmilkov dsmilkov commented Feb 5, 2024

Add support for calling mistral for titling, but without adding public API yet.

  • Add generate_title_mistral and generate_category_mistral titling functions.
  • change the internal cluster_impl so we can override the cluster titling and category titling functions to use those
  • At a later PR when we are happy with quality, we can switch to those by default.

@dsmilkov dsmilkov requested review from nsthorat and brilee February 5, 2024 21:05
nsthorat
nsthorat approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@nsthorat nsthorat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing work!

lilac/data/cluster_titling.py Outdated Show resolved Hide resolved
lilac/data/cluster_titling.py Outdated Show resolved Hide resolved
lilac/data/cluster_titling.py Outdated Show resolved Hide resolved
lilac/data/cluster_titling.py Outdated Show resolved Hide resolved
lilac/data/cluster_titling.py Outdated Show resolved Hide resolved
lilac/data/dataset.py Show resolved Hide resolved
lilac/data/dataset.py Show resolved Hide resolved
@dsmilkov dsmilkov enabled auto-merge (squash) February 8, 2024 19:26
@dsmilkov dsmilkov disabled auto-merge February 8, 2024 19:31
@dsmilkov dsmilkov merged commit 6cb4f72 into main Feb 8, 2024
4 checks passed
@dsmilkov dsmilkov deleted the ds-cluster-mistral branch February 8, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brilee brilee brilee approved these changes

@nsthorat nsthorat nsthorat approved these changes

Assignees
No one assigned
Labels
backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsmilkov @nsthorat @brilee