Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ValidationJob MUST NOT index sub-set reports #115

Open
1 of 2 tasks
kjgarza opened this issue Feb 10, 2020 · 0 comments
Open
1 of 2 tasks

ValidationJob MUST NOT index sub-set reports #115

kjgarza opened this issue Feb 10, 2020 · 0 comments
Labels
enhancement

Comments

@kjgarza
Copy link
Contributor

kjgarza commented Feb 10, 2020 •
edited
Loading

ValidationJob of sub-set reports both validates and pushes the report to the Events Index.
This should be separated into two operations rather than one single operation.

Technical proposal

Separate the actions and in the normal workflow make validation :after_save and push in :after_commit

Planned PRs

Backend

  • [Push all not validate reports](MR link if it already exists)
  • Added corrected logging with lograge
@kjgarza kjgarza self-assigned this Feb 10, 2020
kjgarza added a commit that referenced this issue Feb 10, 2020
@kjgarza
ValidationJob MUST NOT index sub-set reports if not intended
31a6bcf 
addresses #115
@kjgarza kjgarza mentioned this issue Feb 10, 2020
Merged
8 tasks
@kjgarza kjgarza removed their assignment Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kjgarza