Support selecting from local files #152
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Sep 20, 2024
| @@ -15,18 +15,18 @@ | |||
| // specific language governing permissions and limitations | |||
There was a problem hiding this comment.
I renamed the tests from 'extensions' to 'execution' to better reflect it is testing execution in general rather than only extension execution
| // session_ctx.enable_url_table(); | ||
| // expecting that to work, but it didn't as the code returns a new session context | ||
| // instead of modifying the existing one | ||
| let session_ctx = session_ctx.enable_url_table(); |
There was a problem hiding this comment.
this is the only change needed (it is a nice API thanks to @goldmedal)
There was a problem hiding this comment.
this is pretty awesome
|
This works pretty great -- but it is blocked on the delta.rs upgrade to datafusion 4.2 |
Comment on lines
+77
to
+81
| // TODO file a ticket to make the API consuming!! | ||
| // I did like | ||
| // session_ctx.enable_url_table(); | ||
| // expecting that to work, but it didn't as the code returns a new session context | ||
| // instead of modifying the existing one |
There was a problem hiding this comment.
i agree that would be nicer
There was a problem hiding this comment.
apache/datafusion#12551 tracking tickeet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft:
Closes #125
Hooks up the DynamicCatalogFileProvoder and tests with it