Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When PLS_URL is not set (in development), logging in with oidc crashes #5

Open
foodelevator opened this issue Jan 2, 2025 · 0 comments

Comments

@foodelevator
Copy link
Member

Unlike pkg/pls.check, pkg/pls.GetUserPermissionsForGroup does not make a null check on config.Config.PlsURL.

Not providing an url to pls means to allow everything, so ideally this would then return every permission for the group/system that anyone has (not specifically the user requested). But I kind of think that not supplying the pls url should perhaps not be supported and we should have a better pls thing for local development instead.

Anyways, currently we get invalid memory address or nil pointer dereference which should not be the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant