-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include JSON in repository? #5
Comments
@jochakovsky what's the exact use-case? In general, we want to keep this is a clean tabular data package which means CSV only. However, we also want to support user needs so good to know the requirement :-) |
A popular package such as https://www.npmjs.com/package/country-list could really do with getting its dependancies from here. |
Currently the npm package country-list is getting the data from here, but it needs to convert it from cvs to json. |
@fannarsh really useful data point. How are you getting this data package? Are you submoduling it, puling it direct from raw or getting it from data.okfn.org/data/country-list? I note the latter already has a JSON version via the API but it sounds like having json would be useful. Let me know a bit more about what you'd like and let's see if we can get it working for you 😄 |
Currently I'm pulling it once (per update) from raw and then converting it to json and storing it in my repo. |
@fannarsh that's really useful clarification. And the idea about building to a npm package is a really nice idea. If we did to npm package i assume you'd want it as JSON or would CSV work (or both)? And would it literally just be the raw data in there (plus datapackage.json)? |
I would just add the JSON, and I wouldn't bother adding the datapackage.json either since its my understanding it's metadata about the CSV data/structure. |
I added a pull request with an npm package definition that would be good enough for my use case. |
@fannarsh reviewing the PR and thank-you for this Just wondering atm about whether we want in this repo or in a separate repo - we may not want node stuff in here but rather in a small separate repo. |
@fannarsh just to say i'm working on this - classic coder issue of trying to make something generic to generate these automatically. If i don't get this sorted soon I'll just take your version and post ... |
hehe, no sweat, I recognise that problem :) |
@fannarsh @jochakovsky we have something to check out now - a npm/node branch in this repo and a published package on npm https://github.com/datasets/country-list/tree/npm https://www.npmjs.com/package/@datasets/country-list It would be great to get your feedback and thoughts here, especially as going forward we are committed to doing this node packaging for more and more of the core datasets. For example:
Any other comments or thoughts warmly welcome. Aside: we have never forgotten about this. It has just taken a crazy long time for various reasons including some classic yak-shaving: we've been doing a major reboot of https://data.okfn.org and https://datahub.io/ -- which have merged together. Part of that is being able to do a lot of automation ranging from generating the json to generating node packages from data packages ...). |
Hi @rufuspollock, I like what you guys have done so far. I think that you should keep the packages under // https://github.com/datasets/country-list/blob/npm/index.js
let countryList = require('@datasets/country-list-data');
// instead of
let countryList = require('./data.json'); But that all depends on how you want to maintain the packages/repos. If you would not want to release a pure rawData = countries.data() Regarding other datasets, I would say bring them all on 😄 but in reality, workwise it would maybe make sense to start of with |
@fannarsh cool and really useful feedback. Would you like to contribute here - we could give you perms. Also folks on our team like @zelima and @svetozarstojkovic can provide support and guidance 😄 |
http://data.okfn.org/data/core/country-list makes both CSV and JSON formats available for download, but only the CSV is directly available in this repository. Would it be possible to include the JSON in this repository as well? Thank you!
The text was updated successfully, but these errors were encountered: