Fixes issue-257: Sets write consistency on Batch statement #258
Conversation
|
@arvy could you update the manual testing steps on this PR description for future reference? Thanks for the PR! |
There was a problem hiding this comment.
Hi, Thanks for looking into this, however I think it is not needed as the individual statements within the batch are already set with the right consistency-level. See TargetUpdateStatement & TargetInsertStatement for details.
Did you observe an issue with the write-consistency?
Sorry, I did not see your earlier comments, & looks like batches are ignoring consistency on individual statements. |
|
More context on my urgency: Sony has described many issues with inconsistent discrepancies when running validation job, which were most likely due to this bug (Datastax support case 00091967) |
I would be suspicious if you are seeing many issues as we have not found evidence of such issues for other customers & we have done many migrations as well as validations for very large clusters. If the target env is Astra, then write consistency issue is not possible as Astra will auto use |
msmygit
force-pushed
the
issue-257
branch
2 times, most recently
from
1297a34 to
52b9683
Compare
Sets consistency level on batch statements:
Which issue(s) this PR fixes:
Fixes #257
I have tested this manually, using query tracing - I have validated that this is indeed an issue and this PR does fix it.
Any ideas for an automated test welcome :)
Steps for manual acceptance test:
cqlsh> TRUNCATE system_traces.sessions; TRUNCATE system_traces.events;)nodetool settraceprobability 1.0)cqlsh> select * from system_traces.sessions)