Adds support for Instagram API v1 and v2 mappers #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whiteshadow-gr
force-pushed
the
ds-303-instagram-mapper
branch
from
a4f4202 to
08a8ce8
Compare
whiteshadow-gr
changed the title
augustinas
suggested changes
May 11, 2020
There was a problem hiding this comment.
Update the mappers according to the changes requested for the Instagram plugin PR#48
whiteshadow-gr
force-pushed
the
ds-303-instagram-mapper
branch
from
08a8ce8 to
cedd691
Compare
whiteshadow-gr
force-pushed
the
ds-303-instagram-mapper
branch
from
cedd691 to
700e9ae
Compare
whiteshadow-gr
force-pushed
the
ds-303-instagram-mapper
branch
from
700e9ae to
62400a7
Compare
augustinas
reviewed
May 15, 2020
| List(EndpointQuery("instagram/feed", None, | ||
| unixDateFilter.map(f ⇒ Seq(EndpointQueryFilter("ds_created_time", None, f))), None)), Some("ds_created_time"), Some("descending"), None) | ||
|
|
||
| Seq(propertyQueryv2, propertyQueryv1) //ordering is on purpose |
There was a problem hiding this comment.
what does this ordering impact?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for v1 and v2 of the Instagram API items.
Adds more unit tests regarding instagram mappers