Skip to content
This repository has been archived by the owner on Nov 5, 2019. It is now read-only.

Move license in readme and fixes #27 #29

Merged
merged 1 commit into from
Oct 28, 2017
Merged

Conversation

dcwalk
Copy link
Member

@dcwalk dcwalk commented Oct 28, 2017

Moved the license to conform with where we have it generally in our readme

@titaniumbones
Copy link
Contributor

looks good, assuming those failed tests are not your fault!

@titaniumbones titaniumbones merged commit d02d1e6 into master Oct 28, 2017
@b5
Copy link
Member

b5 commented Oct 28, 2017

somehow @ibnesayeed's dockerfile improvements were merged in with this commit, and we haven't had a proper chance to review yet, which is now breaking our master build.

I'd like to put a pause on any merges to master this repo until we've all had a chance to get our heads around @patcon and @ibnesayeed 's enhancements, so we can bring this sweet sweet stuff to all the other service-oriented repos. Unfortunately, the earliest I'm going to be able to get to it is Tuesday :/

On the upside we now know what happens when we merge the new dockerfile as-is :)

@dcwalk
Copy link
Member Author

dcwalk commented Oct 28, 2017

@b5 -- the dockerfile & makefile changes were merged in via #22 and #23 . Build was failing pre this PR, but agree there should be a pause until build is fixed, made an issue #30.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants