From 927f1e2dc59f2191f3c95dd6bd287c3f09262ccf Mon Sep 17 00:00:00 2001 From: Joel Natividad <1980690+jqnatividad@users.noreply.github.com> Date: Sat, 5 Oct 2024 21:42:58 -0400 Subject: [PATCH] `fetch` & `fetchpost`: apply clippy::ref_option suggestion to cached functions --- src/cmd/fetch.rs | 16 ++++++++-------- src/cmd/fetchpost.rs | 16 ++++++++-------- 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/src/cmd/fetch.rs b/src/cmd/fetch.rs index 4ec771bfc..5aea8e224 100644 --- a/src/cmd/fetch.rs +++ b/src/cmd/fetch.rs @@ -798,7 +798,7 @@ pub fn run(argv: &[&str]) -> CliResult<()> { &url, &client, &limiter, - &jql_selector, + jql_selector.as_ref(), args.flag_store_error, args.flag_pretty, include_existing_columns, @@ -816,7 +816,7 @@ pub fn run(argv: &[&str]) -> CliResult<()> { &url, &client, &limiter, - &jql_selector, + jql_selector.as_ref(), args.flag_store_error, args.flag_pretty, include_existing_columns, @@ -838,7 +838,7 @@ pub fn run(argv: &[&str]) -> CliResult<()> { &url, &client, &limiter, - &jql_selector, + jql_selector.as_ref(), args.flag_store_error, args.flag_pretty, include_existing_columns, @@ -878,7 +878,7 @@ pub fn run(argv: &[&str]) -> CliResult<()> { &url, &client, &limiter, - &jql_selector, + jql_selector.as_ref(), args.flag_store_error, args.flag_pretty, include_existing_columns, @@ -1025,7 +1025,7 @@ fn get_cached_response( url: &str, client: &reqwest::blocking::Client, limiter: &governor::RateLimiter, - flag_jql: &Option, + flag_jql: Option<&String>, flag_store_error: bool, flag_pretty: bool, include_existing_columns: bool, @@ -1073,7 +1073,7 @@ fn get_diskcache_response( url: &str, client: &reqwest::blocking::Client, limiter: &governor::RateLimiter, - flag_jql: &Option, + flag_jql: Option<&String>, flag_store_error: bool, flag_pretty: bool, include_existing_columns: bool, @@ -1123,7 +1123,7 @@ fn get_redis_response( url: &str, client: &reqwest::blocking::Client, limiter: &governor::RateLimiter, - flag_jql: &Option, + flag_jql: Option<&String>, flag_store_error: bool, flag_pretty: bool, include_existing_columns: bool, @@ -1170,7 +1170,7 @@ fn get_response( url: &str, client: &reqwest::blocking::Client, limiter: &governor::RateLimiter, - flag_jql: &Option, + flag_jql: Option<&String>, flag_store_error: bool, flag_pretty: bool, include_existing_columns: bool, diff --git a/src/cmd/fetchpost.rs b/src/cmd/fetchpost.rs index 87c1558f9..3548ff100 100644 --- a/src/cmd/fetchpost.rs +++ b/src/cmd/fetchpost.rs @@ -725,7 +725,7 @@ pub fn run(argv: &[&str]) -> CliResult<()> { &form_body_jsonmap, &client, &limiter, - &jql_selector, + jql_selector.as_ref(), args.flag_store_error, args.flag_pretty, args.flag_compress, @@ -745,7 +745,7 @@ pub fn run(argv: &[&str]) -> CliResult<()> { &form_body_jsonmap, &client, &limiter, - &jql_selector, + jql_selector.as_ref(), args.flag_store_error, args.flag_pretty, args.flag_compress, @@ -769,7 +769,7 @@ pub fn run(argv: &[&str]) -> CliResult<()> { &form_body_jsonmap, &client, &limiter, - &jql_selector, + jql_selector.as_ref(), args.flag_store_error, args.flag_pretty, args.flag_compress, @@ -811,7 +811,7 @@ pub fn run(argv: &[&str]) -> CliResult<()> { &form_body_jsonmap, &client, &limiter, - &jql_selector, + jql_selector.as_ref(), args.flag_store_error, args.flag_pretty, args.flag_compress, @@ -961,7 +961,7 @@ fn get_cached_response( form_body_jsonmap: &serde_json::Map, client: &reqwest::blocking::Client, limiter: &governor::RateLimiter, - flag_jql: &Option, + flag_jql: Option<&String>, flag_store_error: bool, flag_pretty: bool, flag_compress: bool, @@ -1013,7 +1013,7 @@ fn get_diskcache_response( form_body_jsonmap: &serde_json::Map, client: &reqwest::blocking::Client, limiter: &governor::RateLimiter, - flag_jql: &Option, + flag_jql: Option<&String>, flag_store_error: bool, flag_pretty: bool, flag_compress: bool, @@ -1067,7 +1067,7 @@ fn get_redis_response( form_body_jsonmap: &serde_json::Map, client: &reqwest::blocking::Client, limiter: &governor::RateLimiter, - flag_jql: &Option, + flag_jql: Option<&String>, flag_store_error: bool, flag_pretty: bool, flag_compress: bool, @@ -1098,7 +1098,7 @@ fn get_response( form_body_jsonmap: &serde_json::Map, client: &reqwest::blocking::Client, limiter: &governor::RateLimiter, - flag_jql: &Option, + flag_jql: Option<&String>, flag_store_error: bool, flag_pretty: bool, flag_compress: bool,