Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable mux-player tracking #105

Open
tedsomething opened this issue Oct 16, 2024 · 6 comments
Open

Disable mux-player tracking #105

tedsomething opened this issue Oct 16, 2024 · 6 comments

Comments

@tedsomething
Copy link

tedsomething commented Oct 16, 2024

I noticed my website trying to ping https://inferred.litix.io/. I got very worried (thinking it was XSS), but it turns out it is due to VideoPlayer, which in turns was mux-player. It seems to me disableTracking should be documented and turned on like disableCookies.

muxinc/elements#614

@arcataroger
Copy link
Member

@theodoregold Thank you for bringing this to our attention! Our developers are discussing what to do about it, and I'll report back here once we have a resolution.

@tedsomething
Copy link
Author

@arcataroger Thanks! DatoCMS is amazing! 🦾

@sistrall
Copy link
Contributor

Hi @theodoregold

nice to meet you.

I just released a preview version of the library that uses a different export strategy for the <VideoPlayer /> component and, also, disables the tracking by default.

import { VideoPlayer } from 'react-datocms'; now uses the eager version of the MUX player: therefore, your bundle size could increase. For that reason, a lazy version of the component is available via import VideoPlayer from "react-datocms/video-player/lazy";.

I hope you have the chance to test this new approach and let me know of any problems you may find: npm add react-datocms@next will install version 8.0.0-1.

@tedsomething
Copy link
Author

Ciao @sistrall

Props to your very cool looking personal website. 👏

I checked it out (and 6a1ec38) and it works great. No issues from me. Everything is as expected. Great job. 👌

My only nitpick would be also updating this here:
https://github.com/datocms/react-datocms/blob/master/docs/video-player.md#props

My apologies for extremely slow reply.

@sistrall
Copy link
Contributor

sistrall commented Nov 8, 2024

Perfect! Thanks @theodoregold !

@sistrall
Copy link
Contributor

Hi @theodoregold

since I had some delay in properly releasing version v8.0.0, I'm cooking a v7.1.0 that includes the disableTracking feature: https://github.com/datocms/react-datocms/releases/tag/v7.1.0-0

@sistrall sistrall reopened this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants