Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read key pair from disk #16

Closed
soyuka opened this issue Jul 31, 2018 · 3 comments
Closed

Read key pair from disk #16

soyuka opened this issue Jul 31, 2018 · 3 comments

Comments

@soyuka
Copy link
Contributor

soyuka commented Jul 31, 2018

Hi, I was reading the code and stumble onto the comment that said "@todo Read key pair from disk". It doesn't look too hard to implement but I had a few questions:

  • Do you already know from where you'd want to read the keys? My guess is that it should use the Storage, not sure!
  • When the keypair doesn't exist (is generated), should it be written to disk (to the Storage?) as well?

Maybe that it's too early in the development to implement this though :).

Cheers.

@yoshuawuyts
Copy link
Contributor

@soyuka hey! It'd be super cool if we could implement this! To answer your questions:

  • yeah, let's store it in the storage
  • when the keypair is generated it should indeed be written to the storage. If we use the memory backend, we'll just have an extra copy in memory - which is fine ✨

You reckon this is something you would want to implement? :D

@soyuka
Copy link
Contributor Author

soyuka commented Aug 10, 2018

Thanks for the answer!

You reckon this is something you would want to implement? :D

Totally, at least try to :). Don't wait for me though if you need it and I'm not there yet (it'd have been a good exercise anyway!). Lot going on in my life currently, but if I can find some time I'd love to do this!

@yoshuawuyts
Copy link
Contributor

@soyuka fantastic! - yeah no, not in a rush for this at all, so happy to wait for you to take a stab at it :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants