Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New features #19

Open
sk3llo opened this issue Oct 24, 2018 · 4 comments
Open

New features #19

sk3llo opened this issue Oct 24, 2018 · 4 comments

Comments

@sk3llo
Copy link

sk3llo commented Oct 24, 2018

Hey! I like your library and I added some functionality to it:

  • "dragDirection" attr (Up/Down/UpAndDown swipes)
  • "finishFragmentByTag" attr (String)
  • "finishFragmentByContainerId" (reference container layout of fragment)
    and some minor bug fixes. But I've done that in kotlin. If you want I can share a code - I dunno how to do pull requests =\
@davidmigloz
Copy link
Owner

Hi sk3llo!

That's awesome 😃
If you don't want to make a PR share the code with me and I'll include it.

I was thinking to migrate the library to Kotlin when a have some spare time, so it'll be a good moment to include your changes.

Thank you!

@sk3llo
Copy link
Author

sk3llo commented Oct 24, 2018

Sorry for slow reply - kinda busy day. I made a simple app to show what I've done. Please check it out and tell me what you think. It's my first contribution hooray lol

@davidmigloz
Copy link
Owner

Thank you very much @sk3llo!
I'll integrate your changes when I work in the Kotlin migration 😄

@sk3llo
Copy link
Author

sk3llo commented Nov 20, 2018

Sounds good 😊

Repository owner deleted a comment from deniskozedub Jan 31, 2024
Repository owner deleted a comment from daino0 Feb 23, 2024
Repository owner deleted a comment from daino0 Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants
@davidmigloz @sk3llo and others