fix: Fixed minitest version failures in the system test builtin tool (#…

…259)
dazuma · May 15, 2024 · 4c62049 · 4c62049
1 parent 97640ed
commit 4c62049
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -46,7 +46,7 @@ jobs:
             ruby: "truffleruby"
             tool: test
           - os: macos-latest
-            ruby: "2.4"
+            ruby: "2.6"
             tool: test
           - os: macos-latest
             ruby: "3.3"

diff --git a/toys/builtins/system/test.rb b/toys/builtins/system/test.rb
@@ -45,12 +45,12 @@ def load_minitest_gems
   gem "minitest", minitest_version
   require "minitest"
   if minitest_focus
-    minitest_focus = "~> 1.0" if minitest_focus == true
+    set :minitest_focus, "~> 1.0" if minitest_focus == true
     gem "minitest-focus", minitest_focus
     require "minitest/focus"
   end
   if minitest_rg
-    minitest_rg = "~> 5.0" if minitest_rg == true
+    set :minitest_rg, "~> 5.0" if minitest_rg == true
     gem "minitest-rg", minitest_rg
     require "minitest/rg"
   end
@@ -82,14 +82,15 @@ def ruby_args
 
 def ruby_code
   code = []
-  code << "gem 'minitest', '= #{::Minitest::VERSION}'"
+  code << "gem 'minitest', #{minitest_version.inspect}"
   code << "require 'minitest/autorun'"
   if minitest_focus
     code << "gem 'minitest-focus', '= #{::Minitest::Test::Focus::VERSION}'"
     code << "require 'minitest/focus'"
   end
   if minitest_rg
-    code << "gem 'minitest-rg', '= #{::MiniTest::RG::VERSION}'"
+    version = defined?(::Minitest::RG::VERSION) ? ::Minitest::RG::VERSION : ::MiniTest::RG::VERSION
+    code << "gem 'minitest-rg', '= #{version}'"
     code << "require 'minitest/rg'"
   end
   code << "require 'toys'"