fix: Clean up some requires #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dazuma
force-pushed
the
pr/require-cleanup
branch
from
38cf201
to
b180b59
Compare
dazuma
force-pushed
the
pr/require-cleanup
branch
from
b180b59
to
17cf044
Compare
dazuma
force-pushed
the
pr/require-cleanup
branch
from
17cf044
to
f8f52a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Went through and made sure requires are correct and in the right places. Also eliminated a few requires that weren't strictly necessary, and deferred a few others into major object constructors so they don't show up in bundles unless absolutely necessary. Among the changes, Toys no longer eagerly requires
stringio, allowing a subsequent bundle to control it, which may help alleviate #240.