fix: mainnavigation underneath 1024px viewports (#1970)

* fix: we need that label element in general * updated test
db-ui · Dec 13, 2023 · db24add · db24add
1 parent a3befb9
commit db24add
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 9 deletions.
diff --git a/...ui-elements-stencil/src/components/db-mainnavigation/__tests__/db-mainnavigation.spec.tsx b/...ui-elements-stencil/src/components/db-mainnavigation/__tests__/db-mainnavigation.spec.tsx
@@ -11,6 +11,7 @@ describe('db-mainnavigation', () => {
       <db-mainnavigation>
         <nav class="cmp-mainnavigation" id="mainnavigation">
          <input id="toggle_mainnavigation" type="checkbox">
+         <label class="is-site-name" htmlfor="toggle_mainnavigation" title="Toggle main navigation"></label>
          <ul></ul>
        </nav>
       </db-mainnavigation>

diff --git a/packages/db-ui-elements-stencil/src/components/db-mainnavigation/db-mainnavigation.tsx b/packages/db-ui-elements-stencil/src/components/db-mainnavigation/db-mainnavigation.tsx
@@ -137,15 +137,13 @@ export class DbMainnavigation {
     return (
       <nav class="cmp-mainnavigation" id="mainnavigation">
         <input type="checkbox" id="toggle_mainnavigation" />
-        {this.siteName && (
-          <label
-            htmlFor="toggle_mainnavigation"
-            title="Toggle main navigation"
-            class="is-site-name"
-          >
-            {this.siteName}
-          </label>
-        )}
+        <label
+          htmlFor="toggle_mainnavigation"
+          title="Toggle main navigation"
+          class="is-site-name"
+        >
+          {this.siteName}
+        </label>
         {this.compData && <ul innerHTML={getCompDataHtml(this.compData)} />}
         {!this.compData && (
           <ul>