Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashes in dispatch_group handling #88

Open
chrissearle opened this issue Nov 4, 2016 · 1 comment
Open

Crashes in dispatch_group handling #88

chrissearle opened this issue Nov 4, 2016 · 1 comment
Labels

Comments

@chrissearle
Copy link
Collaborator

No description provided.

@chrissearle chrissearle added the bug label Nov 4, 2016
@chrissearle
Copy link
Collaborator Author

Investigate using NSOperation/NSOperationQueue

The queue can be set to only allow one operation at a time and operations can be cancelled (individually or all in queue).

So we could have things like "yawOperation", "takePhotoOperation" and on timeout we cancel.

This would avoid having to maintain dispatch group counts, and cancel should help us avoid race conditions - issues with both of which can lead to a double group leave which is represented heavily in the crash list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant