From 97fc75cbf6fbb78189e244dc682fdc6d8109f93a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Doru=20Bl=C3=A2nzeanu?= <dblnz@pm.me>
Date: Wed, 13 Nov 2024 14:04:30 +0200
Subject: [PATCH] Add defaults to arguments of container image Dockerfile
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Doru Blânzeanu <dblnz@pm.me>
---
 .devcontainer/Dockerfile | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/.devcontainer/Dockerfile b/.devcontainer/Dockerfile
index 2616362b..84f89d57 100644
--- a/.devcontainer/Dockerfile
+++ b/.devcontainer/Dockerfile
@@ -2,9 +2,9 @@
 
 FROM mcr.microsoft.com/devcontainers/base:debian AS base
 
-ARG USER
-ARG GROUP
-ARG RUST_TOOLCHAIN
+ARG USER=vscode
+ARG GROUP=vscode
+ARG RUST_TOOLCHAIN=1.81.0
 
 ENV HOME="/home/${USER}"
 ENV PATH="$HOME/.cargo/bin:$PATH"
@@ -37,21 +37,21 @@ RUN wget https://apt.llvm.org/llvm.sh \
 FROM base AS dev
 
 # Make sure the devcontainer user has sudo access
-RUN chown -R "${USER}:$GROUP" /home/${USER} \
+RUN chown -R "${USER}:${GROUP}" /home/${USER} \
     && echo "${USER} ALL=(ALL) NOPASSWD:ALL" >> /etc/sudoers
 
 # Persist bash hystory
 RUN SNIPPET="export PROMPT_COMMAND='history -a' && export HISTFILE=/commandhistory/.bash_history" \
     && mkdir /commandhistory \
     && touch /commandhistory/.bash_history \
-    && chown -R $USER /commandhistory \
-    && echo "$SNIPPET" >> "/home/$USER/.bashrc"
+    && chown -R "${USER}" /commandhistory \
+    && echo "$SNIPPET" >> "/home/${USER}/.bashrc"
 
 USER $USER
 
 # Install rust
 RUN curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y \
-    && rustup default $RUST_TOOLCHAIN \
+    && rustup default ${RUST_TOOLCHAIN} \
     && rustup target add x86_64-unknown-linux-gnu \
     && rustup target add x86_64-unknown-none      \
     && rustup target add x86_64-pc-windows-msvc   \