Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matching substrings, and window disappearing #8

Open
HughMacdonald opened this issue Dec 6, 2013 · 4 comments
Open

Matching substrings, and window disappearing #8

HughMacdonald opened this issue Dec 6, 2013 · 4 comments

Comments

@HughMacdonald
Copy link

Hey Ben,

Someone (Jon, maybe? Possibly Sean) mentioned TabTabTab to me at the Nuke 8 launch event last night, and I thought I'd check it out today.

I love the idea of sorting by the most added nodes - that's definitely useful.

One thing that may have been deliberate, but isn't quite intuitive to me, is that it will only slow matches that start with the same letter.

I reckon that you should be able to type "expr" and have it give you options of Expression, MergeExpression, ParticleExpression and DeepExpression

The other thing is (again, probably deliberate) is that I knocked the mouse and the pop-up disappeared. I would prefer it to act the same way as Nuke's built-in one and not disappear until something else is clicked, or a node is selected to be added.

What do you think of these?

@dbr
Copy link
Owner

dbr commented Feb 2, 2014

I reckon that you should be able to type "expr" and have it give you options of Expression, MergeExpression, ParticleExpression and DeepExpression

This was what I tried first, but found it caused far more unhelpful matches, and required more typing.. whereas the current behaviour quickly allows you to narrow the nodes down to maybe 1 or 2 options

If you want to try out the behaviour, modify the line (around line 241):

if nonconsec_find(filtertext, uiname.lower(), anchored=True):

changing it to anchored=False

There are a few cases where the "match anywhere" behaviour could be useful (like finding a node which "might be named "BlurTweaked" or "TweakedBlur"), but generally for day-to-day work I found the anchored-searching much more usable

Hm, a possible compromise might be to anchor on capital letters, instead of only on the first letter (e.g e would match MergeExpression because the second "word" starts with e)

I would prefer it to act the same way as Nuke's built-in one and not disappear until something else is clicked, or a node is selected to be added

Ah, I intended to match the behaviour of the builtin dialog, but there is a small difference:

  • With the builtin widget: when you click elsewhere, it de-activates the text box. Clicking a second time hides the dialog
  • With tabtabtab: the dialog disappears after the first click.

Presumably you have focus-follows-mouse enabled, which causes the dialog to disappear as soon as the mouse leaves the window

Should be easy enough to fix

@dbr
Copy link
Owner

dbr commented Jan 27, 2016

Oops, forgot about this - the word-separator-anchor would be worth trying. Another solution might be to have /abc do match-anywhere search for abc - similar to [space]abc which does literal search (should document that also)

@dbr
Copy link
Owner

dbr commented Aug 31, 2016

Other simple option would be to append the non-anchored results after the current results (so cam would show Camera and CameraThing, then a separator, then Export Camera thing, Noncamera)

@xavinitram
Copy link

Hi there! 😃
Any updates on the substring matching?
I vote for the asterisc, as in *blur would return Blur, VectorBlur, MotionBlur, EdgeBlur, TimeBlur. Also the idea of first returning the direct matches and then the substring matches is a very good one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants