Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow setting lakeformation tags in cross account catalogs #753

Open
1 task done
DeltiKron opened this issue Nov 4, 2024 · 0 comments
Open
1 task done

allow setting lakeformation tags in cross account catalogs #753

DeltiKron opened this issue Nov 4, 2024 · 0 comments

Comments

@DeltiKron
Copy link

Is this your first time submitting a feature request?

  • I have searched the existing issues, and I could not find an existing issue for this feature

Describe the feature

I have a use case where i want to set Lake Formation Tags on a table which is part of a database in a different account.

As far as I understand, the adapter always assumes that glue databases and catalog are located in the account from which the query is executed. For me this leads to a LakeFormation error as the adapter creates a database in the query account and attempts to apply LF-Tags the tags to this local Database.

I assume that my usecase should work if the catalogId can be added to the table resource in

table_resource = {"Table": {"DatabaseName": self.database, "Name": self.table}}

#414 (comment)
Describes a similar issue.

Describe alternatives you've considered

No response

Who will this benefit?

Makes the athena adapter more useful for data lake and data mesh applications with multi-account setups.

Are you interested in contributing this feature?

Sure, if the change isn't too much effort. Let me know if you're open to a PR.

Anything else?

Schema for the underlying boto3 call:
https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/lakeformation/client/add_lf_tags_to_resource.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant